jobutils/taskwrapper: use fairmq-shmmonitor#5422
Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom Feb 10, 2021
Merged
Conversation
* parse DPL session id and use fairmq-shmmonitor for shared memory cleanup (in case this leaked). The solution based on lsof is deprecated. * this enables also the possibility to monitor shared memory consumption (and report the max value)
Member
|
Why parsing the session and not simply setting it? DPL does take |
Collaborator
Author
|
I am not in control of people using taskwrapper so I can't be sure that session is set. |
Collaborator
Author
|
@ktf : I think if you printed out the session id in logs, it could make things a bit cleaner. Merging for now since actual improvement. |
Member
|
I can do that, but I still do not understand, the taskwrapper could simply add |
Collaborator
Author
|
But if the user already chose a particular session? I would still have to detect/parse it. That can eventually be done of course. |
Collaborator
|
That would require some parsing first. The task wrapper can be used for non-fmq tasks. And also there might already be a session in the command line. And one would require some logic to generate a random session, since 2 taskwrappers might run in parallel. Personally, I'd rather keep the taskwrapper script simple.
…On February 10, 2021 8:46:38 AM GMT+01:00, Giulio Eulisse ***@***.***> wrote:
I can do that, but I still do not understand, the taskwrapper could
simply add `--session <unique-taskwrapper-id>` to whatever it executes
no?
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
#5422 (comment)
|
Member
Ok, I guess this is what I was missing, because if it was, you could simply pass the session as an argument. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse DPL session id and use fairmq-shmmonitor for shared
memory cleanup (in case this leaked). The solution based on
lsof is deprecated.
this enables also the possibility to monitor shared memory
consumption (and report the max value)